Add concurrent pull XComs example in Go-SDK e2e test#68934
Open
jason810496 wants to merge 3 commits into
Open
Conversation
jason810496
force-pushed
the
ci/go-sdk/add-goroutine-example
branch
from
b80f7ee to
dface76
Compare
jason810496
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jscheffl and
potiuk
as code owners
phanikumv
reviewed
Jun 25, 2026
jason810496
force-pushed
the
ci/go-sdk/add-goroutine-example
branch
from
dface76 to
341e260
Compare
uranusjr
approved these changes
Jun 26, 2026
uranusjr
left a comment
uranusjr
left a comment
Member
There was a problem hiding this comment.
One minor suggestion (the current approach works with Go 1.24 so it’s not critical)
Comment on lines
+86
to
+92
| for i, key := range keys { | ||
| wg.Add(1) | ||
| go func() { | ||
| defer wg.Done() | ||
| concResults[i], errs[i] = pull(key) | ||
| }() | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| for i, key := range keys { | |
| wg.Add(1) | |
| go func() { | |
| defer wg.Done() | |
| concResults[i], errs[i] = pull(key) | |
| }() | |
| } | |
| for i, key := range keys { | |
| wg.Add(1) | |
| go func(i int, key string) { | |
| defer wg.Done() | |
| concResults[i], errs[i] = pull(key) | |
| }(i, key) | |
| } |
suggested by Claude to be explicit. I don’t know what Go people generally prefer (according to Claude, the syntax without arguments only works after 1.22) but passing explicit values to a lambda call is generally better in many languages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
One of the most significant feature of Golang programming language is the goroutine. We should definitely add an example to showcase the injected
clientis safe to access the Airflow models (XCom, Variable, Connection) within and across goroutines for Go-SDK.What
Add a new Go Dag example that pull the XComs with
WaitGroupwhich will also be tested in e2e test.Was generative AI tooling used to co-author this PR?